Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs.download: prefer generic.copy over fsspec fs.get() #9753

Merged
merged 1 commit into from
Jul 24, 2023
Merged

fs.download: prefer generic.copy over fsspec fs.get() #9753

merged 1 commit into from
Jul 24, 2023

Conversation

pmrowla
Copy link
Contributor

@pmrowla pmrowla commented Jul 24, 2023 •
edited
Loading

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

Fixes #8964
See iterative/dvc-objects#214 (comment)

@pmrowla pmrowla added the A: data-sync Related to dvc get/fetch/import/pull/push label Jul 24, 2023
@pmrowla pmrowla self-assigned this Jul 24, 2023
This was referenced Jul 24, 2023
Closed
Closed
@pmrowla pmrowla force-pushed the fs-download-copy branch 2 times, most recently from 108c2f1 to 894cefa Compare July 24, 2023 06:49
@codecov
Copy link

codecov bot commented Jul 24, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (a9d0ac2) 90.46% compared to head (ab72708) 90.47%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #9753   +/-   ##
=======================================
  Coverage   90.46%   90.47%           
=======================================
  Files         480      480           
  Lines       36585    36595   +10     
  Branches     5261     5264    +3     
=======================================
+ Hits        33098    33108   +10     
  Misses       2889     2889           
  Partials      598      598
Impacted Files Coverage Δ
dvc/dependency/base.py 57.77% <100.00%> (ø)
dvc/fs/__init__.py 100.00% <100.00%> (ø)
dvc/repo/get.py 92.59% <100.00%> (-0.27%) ⬇️
dvc/repo/get_url.py 100.00% <100.00%> (ø)
tests/func/repro/test_repro.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pmrowla pmrowla changed the title fs: prefer generic.copy over fsspec fs.get() fs.download: prefer generic.copy over fsspec fs.get() Jul 24, 2023
@pmrowla pmrowla merged commit 7806afd into iterative:main Jul 24, 2023
20 checks passed
@pmrowla pmrowla deleted the fs-download-copy branch July 24, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pmrowla pmrowla

Labels
A: data-sync Related to dvc get/fetch/import/pull/push
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

File names containing [ ] in s3 causes import-url/update to fail
1 participant
@pmrowla